Closed
Conversation
It's not clear what additional tests are wanted. A coverage analysis or another bug report would justify additional tests. Otherwise, the current malformed URL test seems adequate.
Member
|
For some context, the comment was added in this commit: 9dbd924 |
Contributor
|
Since the author of the original commit doesn't work on the project anymore, I'm inclined to say this LGTM. |
Contributor
|
LGTM |
jbergstroem
pushed a commit
that referenced
this pull request
Jun 4, 2015
It's not clear what additional tests are wanted. The current malformed URL test seems adequate. PR-URL: #1875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Member
|
Merged in 6537fd4. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear what additional tests are wanted.
A coverage analysis or another bug report would justify
additional tests.
Otherwise, the current malformed URL test seems adequate.
ref #264